Sync with upstream to release 2.8.1 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… study (#779) * Fix unfunctional cancel button handlers in AlertsAndActionSheets case study * Fix tests * Removes *CancelTapped actions from AlertsAndActionSheets case study
* Update bindable helpers docs * wip
* Fix macOS <11 builds with Xcode 13 RC Fixes #796. * wip * Update Tests/ComposableArchitectureTests/ViewStoreTests.swift Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>
* Remove old deprecations * wip
* Use thread dictionary for check instead * Improve thread check messaging for Store.scope * typo fix Co-authored-by: Brandon Williams <mbrandonw@hey.com>
…binding (#810) * wip * wip
* Clean up speech recognition case study. * fix tests * clean up;
* Fix Bindable Deprecations * More CI * wip * wip * wip * wip
* Added observedSelf property to ViewStore * Created ObservedViewStore * Try projectedBinding first for ViewStore bindings * Replaced @ObservedObject with @ObservedViewStore * Revert "Replaced @ObservedObject with @ObservedViewStore" This reverts commit 6aadf373db58a2320c582741a76794ac3d6bfc43. * Revert "Try projectedBinding first for ViewStore bindings" This reverts commit 0e2fae1cbf53e84194a6fb3a5eb077021110c395. * Revert "Created ObservedViewStore" This reverts commit 7f99a718b96d186324627ef6d016a882e83e9f8e. * Revert "Added observedSelf property to ViewStore" This reverts commit 65dc3837b37d8251c2d1e2916c94894b8eb93db0. * Replaced self.binding with projectedValue * Revert "Replaced self.binding with projectedValue" This reverts commit cc2b69777e63a8b8cee40df5d5db9557302177cd. * Derive bindings using WrappedState helper * wip * wip * wip * avoid potential retain cycle * Revert "Derive bindings using WrappedState helper" This reverts commit f3fb18f4458f47d28905e8b346c767fbd05b7f99. Co-authored-by: Stephen Celis <stephen@stephencelis.com>
* Update AlertState to use new APIs * fix * Feedback * wip * Fix * wip * wip * wip * wip
* Perform thread check only when store is created on main thread. * clean up * Update Sources/ComposableArchitecture/Store.swift * clean up * Update Sources/ComposableArchitecture/Store.swift * clean up * execute setSpecific only once. * logic fix * added a test * typo * wip * docs * fix test * Update Sources/ComposableArchitecture/Store.swift Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com> * Run swift-format * Clean up speech recognition case study. (#812) * Clean up speech recognition case study. * fix tests * clean up; * Alternative to `CurrentValueSubject` in `ViewStore` (#755) * Replaced CurrentValueSubject with CurrentValueRelay * Added final to DemandBuffer Co-authored-by: Brandon Williams <mbrandonw@hey.com> * Run swift-format * Fix bindable deprecations (#815) * Fix Bindable Deprecations * More CI * wip * wip * wip * wip * Run swift-format * beef up test * expectation * fix Co-authored-by: Stephen Celis <stephen@stephencelis.com> Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com> Co-authored-by: stephencelis <stephencelis@users.noreply.github.com> Co-authored-by: iampatbrown <mrpatbrown@gmail.com> Co-authored-by: mbrandonw <mbrandonw@users.noreply.github.com>
* Check main thread via Thread.isMainThread * wip * wip
Due to private `StoreObservableObject` this has to be implemented as part of the library
mluisbrown
force-pushed
the
sync/upstream-2.8.1
branch
from
dbd257b
to
cdde86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.