Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear all filters UX tweaking #19

Closed
miohtama opened this issue Mar 11, 2022 · 1 comment · Fixed by #24
Closed

Clear all filters UX tweaking #19

miohtama opened this issue Mar 11, 2022 · 1 comment · Fixed by #24
Assignees
@kenkunz

Comments

@miohtama
Copy link
Contributor

miohtama commented Mar 11, 2022 •
edited
Loading

When none of the filters are selected, the default "Clear all filters" button is confusing

image

User (me) tries to press it.

This is because it is not obvious it is greyed out button. I suggest hiding it altogether when no filters are selected or change it to label "Select filters:" that then will change to "Clear filters" button if any of the filters are selected. Something along this lines.
@kenkunz
Copy link
Contributor

kenkunz commented Mar 11, 2022

Makes sense. I lean towards your second suggestion (mutating label) – will experiment a bit.

kenkunz added a commit that referenced this issue Mar 15, 2022
@kenkunz
improve clear-filters button
3c9e13f 
resolves #19
@kenkunz kenkunz mentioned this issue Mar 15, 2022
Merged
kenkunz added a commit that referenced this issue Mar 16, 2022
@kenkunz
improve clear-filters button
220abe4 
resolves #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenkunz kenkunz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve clear filters UI tradingstrategy-ai/frontend
2 participants
@kenkunz @miohtama