[WIP] Japan example app

[gigiyy]

No description provided.

[falnatsheh]

Any thoughts on having btLimit and btMarket boolean in the ViewModel vs here?

[gigiyy]

they are actually the button itself, here we're make it selected or not. however it can be made more concise or nature if keep the status in viewModel and linked them together. I'll try

[gigiyy]

using the model turns out a better solution. I've got a OrderType in my OrderInfo already.

[falnatsheh]

In Swift you could remove orderForm.value = value?.apply { and replace it with orderForm?.value, like the following:

if (orderInfo?.limitPrice < symbol.priceUpperLimit) {
         orderInfo = orderInfo.copy(limitPrice = orderInfo.limitPrice + 1)
 }

Can you do that in Kotlin?

[gigiyy]

yes. they can be inlined. updated similar places.

[falnatsheh]

!this::orderForm.isInitialized is needed? since this is the init of the class I assume this::orderForm.isInitialized will return false

[gigiyy]

when screen rotates, Fragment will call init again. however we don't need to init the ViewModel since we should reuse the model in this case. I'm still looking if there is a way to call this init only once and when it's needed. (need to dig into how Fragment works for this)

[falnatsheh]

When configuration changes the fragment is destroyed and then recreated by the fragment manager. However the ViewModel survives configuration changes so when the activity is recreated and you call the ViewModelProviders here you actually get the same instance. https://developer.android.com/topic/libraries/architecture/viewmodel#lifecycle

[gigiyy]

the view model factory works well. removed the init method now.

[falnatsheh]

To init a ViewModel you need to create custom factory and use it with ViewModelProviders: https://android.jlelse.eu/android-viewmodel-with-custom-arguments-d0ff0fba29e1