Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of detecting touch/non-touch devices #106

Closed
timocov opened this issue Jul 8, 2019 · 0 comments · Fixed by #972
Closed

Get rid of detecting touch/non-touch devices #106

timocov opened this issue Jul 8, 2019 · 0 comments · Fixed by #972
Assignees
@Ffloriel
Labels
enhancement Feature requests, and general improvements.
Milestone
3.8

Comments

@timocov
Copy link
Contributor

timocov commented Jul 8, 2019

Currently MouseEventHandler and widgets like PaneWidget use detection of the device type to determine what type of event subscribe for and what to do in several cases (long tap event, dragging, tracking mode).

In a lot of cases we don't need to detect it, we can subscribe on all needed event with separate handles and there we'll know what's happened (touch event or mouse one). It requires some refactoring in MouseEventHandler and detecting that an event is emulated from original one (mouse event from touch for instance).

Don't forget about this.

I believe in the PR for this issue we can remove https://github.com/tradingview/lightweight-charts/blob/6f132374ed82b31f3b1e66837b2956470057a50d/src/gui/support-touch.ts module at all.

Related links:
@timocov timocov added the enhancement Feature requests, and general improvements. label Jul 8, 2019
@timocov timocov added the breaking change Changes the API in a non backwards compatible way. label Mar 6, 2020
@timocov timocov mentioned this issue Sep 22, 2020
Closed
@timocov timocov added this to the Future milestone Oct 26, 2020
@timocov timocov modified the milestones: Future, 4.0 Nov 13, 2020
@timocov timocov mentioned this issue Dec 21, 2020
Closed
@timocov timocov mentioned this issue Nov 16, 2021
Closed
@Ffloriel Ffloriel mentioned this issue Jan 12, 2022
Merged
3 tasks
@timocov timocov modified the milestones: 4.0, 3.8 Jan 17, 2022
@timocov timocov removed the breaking change Changes the API in a non backwards compatible way. label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ffloriel Ffloriel

Labels
enhancement Feature requests, and general improvements.
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

feat: add option to activate scroll on touch end event tradingview/lightweight-charts
2 participants
@timocov @Ffloriel