Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to activate scroll on touch end event #972

Merged
merged 14 commits into from
Jan 19, 2022

Conversation

Ffloriel
Copy link
Contributor

@Ffloriel Ffloriel commented Jan 12, 2022

Type of PR: enhancement

PR checklist:

Overview of change:

  • Update MouseEventHandler, separating the mouse and touch events (related to Get rid of detecting touch/non-touch devices #106)
  • Add quick tracking option, to activate scroll on touch end event instead of having to click after to reactivate the scroll.

@timocov timocov requested a review from kirchet January 12, 2022 10:05
src/gui/support-touch.ts Outdated Show resolved Hide resolved
tests/e2e/coverage/coverage-config.ts Show resolved Hide resolved
src/typings/_global-types/index.d.ts Outdated Show resolved Hide resolved
src/gui/last-touch-or-mouse-event.ts Outdated Show resolved Hide resolved
src/helpers/events.ts Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
src/gui/mouse-event-handler.ts Outdated Show resolved Hide resolved
Co-authored-by: Evgeniy Timokhov <timocov@gmail.com>
src/gui/pane-widget.ts Show resolved Hide resolved
src/gui/pane-widget.ts Outdated Show resolved Hide resolved
src/gui/pane-widget.ts Show resolved Hide resolved
src/helpers/browsers.ts Outdated Show resolved Hide resolved
Ffloriel and others added 4 commits January 12, 2022 15:41
Co-authored-by: Kirill Chetverikov <kirchet@yandex.ru>
Co-authored-by: Kirill Chetverikov <kirchet@yandex.ru>
- replace activateScrollOnTouchEnd with trackingMode option
- remove support-touch and other unused files
- move window.chrome type to dom-not-standard
- add missing end scroll call for touch event handler
src/gui/pane-widget.ts Outdated Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
.size-limit.js Outdated Show resolved Hide resolved
- fix qualified name bug in typedoc-plugin-markdown
typedoc2md/typedoc-plugin-markdown#283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants