Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to check code usage coverage #495

Closed
timocov opened this issue Jun 25, 2020 · 0 comments · Fixed by #517
Closed

Add test to check code usage coverage #495

timocov opened this issue Jun 25, 2020 · 0 comments · Fixed by #517
Assignees
@timocov
Labels
infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). tests Unit and e2e testing.
Milestone
3.2

Comments

@timocov
Copy link
Contributor

timocov commented Jun 25, 2020 •
edited
Loading

Chrome DevTools has an option to get code coverage reports (how many functions/bytes are unused in JS code).

image

I think we can add another one e2e test, where we can create as much as possible API objects, call a lot of API methods and then get coverage report and compare it with some value (like we did for size or type coverage).

See https://github.com/puppeteer/puppeteer/blob/v4.0.0/docs/api.md#pagecoverage, https://github.com/puppeteer/puppeteer/blob/v4.0.0/docs/api.md#class-coverage.

Related to #496.
@timocov timocov added tests Unit and e2e testing. infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). labels Jun 25, 2020
@timocov timocov self-assigned this Jun 25, 2020
@timocov timocov mentioned this issue Jun 25, 2020
Merged
3 tasks
@timocov timocov modified the milestones: Future, 3.2 Jun 25, 2020
timocov added a commit that referenced this issue Jul 7, 2020
@timocov
Introduced coverage test
885fcf0 
Fixes #495
timocov added a commit that referenced this issue Jul 7, 2020
@timocov
Introduced coverage test
a2256ef 
Fixes #495
@timocov timocov mentioned this issue Jul 7, 2020
Merged
3 tasks
@aravindb26 aravindb26 mentioned this issue Dec 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timocov timocov

Labels
infrastructure Infrastructure surrounding the development of the library (CI, tests, scripts). tests Unit and e2e testing.
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Coverage test tradingview/lightweight-charts
1 participant
@timocov