Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc comments for existing API docs #870

Merged
merged 32 commits into from
Oct 20, 2021

Conversation

edew
Copy link
Contributor

@edew edew commented Oct 13, 2021

Type of PR: enhancement

PR checklist:

  • Documentation update

Overview of change:

This PR moves the hand-written API documentation that currently exists in our docs into JSDoc comments on the appropriate types.

When we have these JSDoc comments we can then use them to auto-generate API documentation.

Theres still work to be done to improve these API docs but this is meant to be a first step that uses the documentation we already have.

src/api/data-consumer.ts Outdated Show resolved Hide resolved
src/api/create-chart.ts Outdated Show resolved Hide resolved
src/api/data-consumer.ts Outdated Show resolved Hide resolved
src/api/ichart-api.ts Show resolved Hide resolved
src/api/ichart-api.ts Show resolved Hide resolved
src/model/price-line-options.ts Outdated Show resolved Hide resolved
src/model/series-options.ts Outdated Show resolved Hide resolved
src/model/time-data.ts Show resolved Hide resolved
src/model/time-data.ts Outdated Show resolved Hide resolved
src/model/watermark.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/model/price-scale.ts Outdated Show resolved Hide resolved
src/model/series-options.ts Outdated Show resolved Hide resolved
src/model/series-options.ts Outdated Show resolved Hide resolved
tsconfig.dts.json Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
src/helpers/color.ts Outdated Show resolved Hide resolved
timocov and others added 3 commits October 19, 2021 12:35
Replaced 0 and 1 with 'off' and 'error' accordingly (it looks like more explicit way to operate with eslint rules)
@edew edew requested a review from timocov October 20, 2021 11:46
src/model/price-scale.ts Outdated Show resolved Hide resolved
src/model/chart-model.ts Outdated Show resolved Hide resolved
@timocov timocov merged commit bb98b6f into tradingview:master Oct 20, 2021
@timocov timocov added this to the 3.7 milestone Oct 20, 2021
@edew edew deleted the add-jsdoc-comments-for-api branch October 20, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants