Add documentation website landing page #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timocov
suggested changes
Jan 24, 2022
subzey
reviewed
Jan 24, 2022
subzey
reviewed
Jan 24, 2022
subzey
reviewed
Jan 24, 2022
subzey
reviewed
Jan 24, 2022
This reverts commit 6e070b1.
timocov
reviewed
Jan 25, 2022
timocov
reviewed
Jan 27, 2022
website/src/pages/index.tsx
Outdated
| const resizeListener = () => { | ||
| const { width, height } = container.getBoundingClientRect(); | ||
| c.resize(width, height); | ||
| c.timeScale().setVisibleLogicalRange({ from: 1, to: data.orangeData.length - 2 }); |
There was a problem hiding this comment.
See https://tradingview.github.io/lightweight-charts/docs/api/interfaces/TimeScaleOptions#lockvisibletimerangeonresize, it seems that this is what you need instead 🙂
timocov
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: enhancement
PR checklist:
Overview of change:
This PR adds a fresh landing page for the documentation website.
Is there anything you'd like reviewers to focus on?
imgtag so the navbar loads two different static svg files.