fix: check for empty dated value

tradle · Jan 2, 2018 · adbf4b7 · adbf4b7
1 parent 6489d45
commit adbf4b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/lib/samplebot/customize.js b/lib/samplebot/customize.js
diff --git a/src/samplebot/customize.ts b/src/samplebot/customize.ts
@@ -8,7 +8,6 @@ import { createConf } from './configure'
 import Errors = require('../errors')
 
 const ONFIDO_PLUGIN_PATH = 'products.plugins.onfido'
-const emptyStringToUndefined = val => val === "" ? undefined : val
 
 export async function customize (opts) {
   let { lambda, bot, delayReady, event } = opts
@@ -27,12 +26,14 @@ export async function customize (opts) {
       Errors.ignore(err, Errors.NotFound)
       return undefined
     }),
-    confy.termsAndConditions.getDatedValue().catch(err => {
-      // TODO: maybe store in local fs instead of in memory
-      Errors.ignore(err, Errors.NotFound)
-      return undefined
-    })
-    .then(emptyStringToUndefined)
+    confy.termsAndConditions.getDatedValue()
+      // ignore empty values
+      .then(datedValue => datedValue.value && datedValue)
+      .catch(err => {
+        // TODO: maybe store in local fs instead of in memory
+        Errors.ignore(err, Errors.NotFound)
+        return undefined
+      })
   ])
 
   const { domain } = org