fix: double-issued employee pass

tradle · Apr 27, 2018 · cda351b · cda351b
1 parent 0a10eac
commit cda351b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/in-house-bot/index.ts b/src/in-house-bot/index.ts
@@ -480,11 +480,16 @@ const tweakProductListPerRecipient = (components: IBotComponents) => {
 
 const approveWhenTheTimeComes = (components:IBotComponents):IPluginLifecycleMethods => {
   const { bot, logger, conf, productsAPI, employeeManager, applications } = components
-  const { autoApprove } = conf.bot.products
+  const { autoApprove, approveAllEmployees } = conf.bot.products
   const onFormsCollected = async ({ req, user, application }) => {
     if (application.draft) return
 
     if (!isPendingApplication({ user, application })) return
+    if (approveAllEmployees && application.requestFor === EMPLOYEE_ONBOARDING) {
+      // handled by bot-employee-manager
+      // yes...this is a bit confusing
+      return
+    }
 
     if (!autoApprove) {
       const results = await Promise.all([

diff --git a/src/in-house-bot/utils.ts b/src/in-house-bot/utils.ts
@@ -329,8 +329,14 @@ const hasApplication = (stubs, application) => {
   return stubs.find(stub => stub.statePermalink === application._permalink)
 }
 
+const judgedStatuses = [
+  'approved',
+  'denied'
+]
+
 export const isPendingApplication = ({ user, application }) => {
-  return hasApplication(user.applications || [], application)
+  return !judgedStatuses.includes(application.status) &&
+    hasApplication(user.applications || [], application)
 }
 
 export const getApplicationStatus = ({ user, application }) => {