Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests #29

Merged
merged 9 commits into from
Jun 17, 2019
Merged

Add integration tests #29

merged 9 commits into from
Jun 17, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jun 12, 2019

Description

This add first integration tests

dtomcej
dtomcej suggested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Some questions though!

Makefile Outdated Show resolved Hide resolved
integration/integration_test.go Show resolved Hide resolved
integration/integration_test.go Outdated Show resolved Hide resolved
integration/resources/compose/k3s.yaml Outdated Show resolved Hide resolved
integration/try/try.go Show resolved Hide resolved
integration/try/try.go Outdated Show resolved Hide resolved
@mmatur
Copy link
Member Author

mmatur commented Jun 13, 2019

Blocked by #34

@dtomcej
Copy link
Contributor

dtomcej commented Jun 13, 2019

@mmatur Unblocked :)

@mmatur mmatur marked this pull request as ready for review June 17, 2019 14:50
dtomcej
dtomcej approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej merged commit a5143be into traefik:master Jun 17, 2019
@dtomcej dtomcej mentioned this pull request Jun 17, 2019
Closed
@mmatur mmatur deleted the feature/integration-tests branch June 17, 2019 16:38
@dtomcej dtomcej mentioned this pull request Jun 17, 2019
Closed
8 tasks
@mmatur mmatur added this to the v0.1.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmatur @dtomcej