Fix panic when pod IP is not yet assigned #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pods with no IP are filtered out in the TopologyBuilder. When collecting the different pods for a TrafficTarget, we are refering to a pod which can have been excluded. This is done without checking if the key is in the map, leading to a panic. This commit intent to be more protective on map access. In the same time, log message and errors have been cleaned so they don't mention two times the same information and use the Key everywhere instead of the "namespace/name" format.
jspdown
force-pushed
the
fix-panic-provider
branch
from
4cabb9f
to
51227f3
Compare
jspdown
force-pushed
the
fix-panic-provider
branch
from
7016430
to
416f7a8
Compare
kevinpollet
added
area/controller
provider/kubernetes
kind/bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pods with no IP are filtered out in the
TopologyBuilder. When collecting the different pods for aTrafficTarget, we are referring to pods which can have been excluded. This is done without checking if the key is in the map, leading to a panic.This PR intent to be more protective when accessing a map element.
In the same time, log message and errors have been cleaned up so they don't mention two times the same information and use the
Keyformat everywhere instead of "namespace/name".How to test it
This can be hard to reproduce as it occurs only when the Provider gets triggered and the Pod informers don't already have pods with an IP assigned. The best way to reproduce this bug is to create many pods at the same time.