Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TCP Routes #52

Merged
merged 13 commits into from
Jun 18, 2019
Merged

Create TCP Routes #52

merged 13 commits into from
Jun 18, 2019

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jun 17, 2019 •
edited

This PR modifies the following:

  • Creates TCP routes (ingressRouteTCP) by default
  • Watches for an annotation to use HTTP
  • Checks the service port type before creating routes, logs a warning if incompatible port is found
  • Ignores services and namespaces set in a wrapper.

Fixes #14, #32, #38, #46, #51

mmatur
mmatur approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur merged commit f8c8094 into traefik:master Jun 18, 2019
@mmatur mmatur deleted the issue-38 branch June 18, 2019 14:48
This was referenced Jun 18, 2019
Closed
Closed
Closed
Closed
@mmatur mmatur added this to the v0.1.0 milestone Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

Move traefik mesh pods from http -> tcp mode
2 participants
@dtomcej @mmatur