Skip to content

Commit

Permalink
fix: 🐛 http3 support on traefik v3
Browse files Browse the repository at this point in the history
  • Loading branch information
mloiseleur committed Jun 2, 2023
1 parent 1f29975 commit c29e3fd
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
4 changes: 3 additions & 1 deletion traefik/templates/_podtemplate.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,10 @@
{{- end }}
{{- if $config.http3 }}
{{- if $config.http3.enabled }}
{{- if semverCompare "<3.0.0-0" (default $.Chart.AppVersion $.Values.image.tag)}}
- "--experimental.http3=true"
{{- if semverCompare ">=2.6.0" (default $.Chart.AppVersion $.Values.image.tag)}}
{{- end }}
{{- if semverCompare ">=2.6.0-0" (default $.Chart.AppVersion $.Values.image.tag)}}
{{- if $config.http3.advertisedPort }}
- "--entrypoints.{{ $entrypoint }}.http3.advertisedPort={{ $config.http3.advertisedPort }}"
{{- else }}
Expand Down
15 changes: 15 additions & 0 deletions traefik/tests/pod-config_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,21 @@ tests:
- contains:
path: spec.template.spec.containers[0].args
content: "--entrypoints.websecure.http3"
- it: should use default entrypoint port without experimental flag when http3 enabled on v3
set:
image:
tag: v3.0.0-beta2
ports:
websecure:
http3:
enabled: true
asserts:
- notContains:
path: spec.template.spec.containers[0].args
content: "--experimental.http3=true"
- contains:
path: spec.template.spec.containers[0].args
content: "--entrypoints.websecure.http3"
- it: should not have http3 config flag by default
asserts:
- notContains:
Expand Down

0 comments on commit c29e3fd

Please sign in to comment.