feat(podtemplate): set GOMEMLIMIT, GOMAXPROCS when limits are defined #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o. that's right @ChandonPierre ! It's confirmed with other blog post and the existence of automaxprocs. |
mloiseleur
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Thanks for this PR 👍
Would you please ensure within a test to ensure there is no GOMAXPROCESS & GOMEMLIMIT when resources are not set (since it's the default behavior) ?
Your PR is clearly not doing that : I'm suggesting to add that, just in case, as a safety net.
Certainly reasonable! Added tests for undefined limits case in 5bd8be3 |
mloiseleur
approved these changes
Apr 8, 2024
This was referenced Apr 30, 2024
This was referenced May 17, 2024
alemorcuq
pushed a commit
to bitnami-labs/sealed-secrets
that referenced
this pull request
May 23, 2024
**Description of the change** Set `GOMAXPROCS` and `GOMEMLIMIT` environment variables based on container resources. Inspired by traefik/traefik-helm-chart#1029. **Benefits** This should reduce potential CPU throttling and OOMKills on containers. **Possible drawbacks** This creates an empty `env` key for those not setting resource values. This is only a little ugly, but should not be harmful. Alternatively, we could add some conditional wrapper around the whole `env` block to only make it appear if a value is set, but that will be more complicated if additional env would be added in the future. **Additional information** The [`resourceFieldRef`](https://kubernetes.io/docs/concepts/workloads/pods/downward-api/#downwardapi-resourceFieldRef) is a very specific Kubernetes directive that is created specifically for passing resource-related values, which rounds up the CPU value to the nearest whole number (e.g. 250m to 1) and passes the memory as a numeric value; so `64Mi` would result in the environment variable being set to `67108864`. This by design makes it completely compatible with Go's API. An example is documented within Kubernetes documentation itself: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/#use-container-fields-as-values-for-environment-variables. --------- Signed-off-by: Jesper Noordsij <jesper.noordsij@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Always define
GOMEMLIMITandGOMAXPROCSenv vars when memory limits and CPU limits are defined.Motivation
Traefik is written in GoLang, and is thus subject to CPU throttling when CPU limits are defined in a container without GOMAXPROCS set. We see this reflected in the
container_cpu_cfs_throttled_seconds_totalmetric in our environment; where CPU throttle rate exceeds 1000%More
make testand all the tests passed