Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding urls that the dashboard will be accessible via to the readme #318

Merged
merged 1 commit into from Dec 30, 2020

Conversation

Bwvolleyball
Copy link
Contributor

For folks who are attempting to follow this helm chart, it's useful to have which urls the traefik dashboard will be accessible via under each scenario, especially since the trailing / is necessary, and it may be unintuitive that the localhost ip address must be used when port-forwarding.

@rtribotte rtribotte added area/documentation Improvements or additions to documentation kind/enhancement New feature or request status/2-needs-review labels Dec 8, 2020
Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bwvolleyball.

That PR needs a minor version bump to pass. Once done, its ready to get merged! :)

@Bwvolleyball
Copy link
Contributor Author

Hello @SantoDE - can you elaborate? These are just documentation changes, so I don't understand what version needs to be bumped. Sorry if this is a silly question..

Copy link
Contributor

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants