Add Acme certificate resolver configuration #419
Conversation
jakubhajek
added
kind/enhancement
| @@ -349,6 +349,27 @@ persistence: | |||
| annotations: {} | |||
| # subPath: "" # only mount a subpath of the Volume into the pod | |||
|
|
|||
| certResolvers: {} | |||
| # letsencrypt: | |||
There was a problem hiding this comment.
I think that indention is not correct, there should 2 white spaces instead of 3.
There was a problem hiding this comment.
It's # (sharp-space) for the comment and two spaces for the indentation.
Other places have a space after the sharp for comments too. Is is a problem?
| # # for challenge options cf. https://doc.traefik.io/traefik/https/acme/ | ||
| # email: email@example.com | ||
| # dnsChallenge: | ||
| # # also add the provider's required configuration under env |
There was a problem hiding this comment.
We have to emphasize that Kubernetes Secret containing DNS provider data is mandatory. Otherwise, a user might be confused about where the sensitive (APK_KEY, login) data should be added.
There was a problem hiding this comment.
I'm a bit confused. How would you rephrase the current comment to be more clear?
traefik/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: traefik | |||
| description: A Traefik based Kubernetes ingress controller | |||
| type: application | |||
| version: 9.19.1 | |||
| version: 9.19.2 | |||
There was a problem hiding this comment.
Would you please update the chart and Traefik version?
|
@jakubhajek This is a pretty important feature, why dont the maintainers just finish the work that was started? |
ddtmachado
added
status/2-needs-review
and removed
contributor/waiting-for-corrections
labels
Being able to configure these options via values is much more friendly than having to write it through additionalArgs.