expose hostnetwork option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rbtr Thanks for your contribution.
Regarding the hostNetwork, what is your use case? I am closing this PR because affinity and env have already been implemented. Could you please open an issue to start a discussion about the hostNetwork. We need to understand the use case behind the needs to bind traefik to node ports 80/443. Thanks |
|
@rbtr After a discussion with the Traefik team we have decided to reopen this PR. |
|
@rbtr Could you please rebase your PR |
mmatur
requested changes
Mar 12, 2020
ldez
changed the title
adds hostNetwork, affinity, and env customization to the values.yaml in the deployment template, adds hostNetwork, affinity (more on this below) and env templates hooks. in the deployment template, adds logic that checks if: - the pod is running in the host network - the deployment has >1 replica specified - there are no antiaffinity rules specified and injects a default pod anti-affinity that will schedule traefik pods on individual nodes (kind of like daemonset behavior, except only on as many nodes as replicas requested)
|
@mmatur rebased and cleaned up per review comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
adds hostNetwork and an example anti-affinity for hostnetwork compatibility.
Why:
I want traefik to bind to the node ports 80/443, but a NodePort service can only bind to ports >3000 (unless k8s is specifically configured to allow a different NodePort range which is not recommended). The only option in this situation is to run the pod in the host network namespace...
But if the pod is running in the host network, we can't schedule more than one per node, because the port will become in-use as soon as the first pod starts, so it is necessary to spread them out among the nodes when we have more than one pod replica.
Closes #99