-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add healthcheck ingressRoute #914
Conversation
Hello @muandane, Thanks for this PR. FTM, I have two questions:
|
Hello @mloiseleur, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR introduces an IngressRoute for health checks, addressing the specific requirements of running in a constrained environment. The proposed changes are in alignment with the project guidelines and seamlessly integrate with the existing codebase. By incorporating this IngressRoute.
Motivation
I'm Deploying private clusters that are behind an Application gateway that has backend probes to check the health of the LoadBalancer (internal load balancers in azure), due to constraints and personally wanting to make it easier for me and everyone to easily get a healthCheck up and running on the desired entryPoint (in the values.yaml I left the entryPoint as traefik so the healthCheck isn't exposed externally).
More
make test
and all the tests passed