Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add healthcheck ingressRoute #914

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Conversation

muandane
Copy link
Contributor

What does this PR do?

This PR introduces an IngressRoute for health checks, addressing the specific requirements of running in a constrained environment. The proposed changes are in alignment with the project guidelines and seamlessly integrate with the existing codebase. By incorporating this IngressRoute.

Motivation

I'm Deploying private clusters that are behind an Application gateway that has backend probes to check the health of the LoadBalancer (internal load balancers in azure), due to constraints and personally wanting to make it easier for me and everyone to easily get a healthCheck up and running on the desired entryPoint (in the values.yaml I left the entryPoint as traefik so the healthCheck isn't exposed externally).

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur changed the title feature ✨ (traefik): added healthcheck ingressRoute feat: ✨ add healthcheck ingressRoute Aug 23, 2023
@mloiseleur
Copy link
Contributor

Hello @muandane,

Thanks for this PR.

FTM, I have two questions:

  1. Why do you think it should be enabled by default ?
  2. Why did you not use extraObjects ?

@muandane
Copy link
Contributor Author

Hello @mloiseleur,
Yes it's not enabled by default since it has the same value capabilities as the Traefik dashboard but also has the same easy way to create an ingressRoute for a healthCheck exposed on whatever entryPoint you need as for the second question tbh i didn't check the extraObjects part since i'm using Ansible tasks to deploy Traefik sometimes it gets constraining on what values i can deploy.

btw the AKS cluster is a private one.
image

traefik/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0725e48 into traefik:master Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants