Skip to content

Commit

Permalink
Merge pull request #1394 from containous/nicgrayson-master
Browse files Browse the repository at this point in the history
Allow traefik.port to not be in the list of marathon ports
  • Loading branch information
emilevauge committed Apr 6, 2017
2 parents e1aa16a + 4eb779e commit 08c1871
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 37 deletions.
15 changes: 1 addition & 14 deletions provider/marathon.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,24 +235,11 @@ func (provider *Marathon) taskFilter(task marathon.Task, applications *marathon.
}
}
if portValueLabel != "" {
port, err := strconv.Atoi((*application.Labels)["traefik.port"])
_, err := strconv.Atoi((*application.Labels)["traefik.port"])
if err != nil {
log.Debugf("Filtering marathon task %s with unexpected value for traefik.port label", task.AppID)
return false
}

var foundPort bool
for _, exposedPort := range ports {
if port == exposedPort {
foundPort = true
break
}
}

if !foundPort {
log.Debugf("Filtering marathon task %s without a matching port for traefik.port label", task.AppID)
return false
}
}

//filter healthchecks
Expand Down
26 changes: 3 additions & 23 deletions provider/marathon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -519,39 +519,19 @@ func TestMarathonTaskFilter(t *testing.T) {
{
task: marathon.Task{
AppID: "specify-port-number",
Ports: []int{80, 443},
},
applications: &marathon.Applications{
Apps: []marathon.Application{
{
ID: "specify-port-number",
Ports: []int{80, 443},
Labels: &map[string]string{
"traefik.port": "80",
},
},
},
},
expected: true,
exposedByDefault: true,
},
{
task: marathon.Task{
AppID: "specify-unknown-port-number",
Ports: []int{80, 443},
Ports: []int{80},
},
applications: &marathon.Applications{
Apps: []marathon.Application{
{
ID: "specify-unknown-port-number",
Ports: []int{80, 443},
ID: "specify-port-number",
Labels: &map[string]string{
"traefik.port": "8080",
},
},
},
},
expected: false,
expected: true,
exposedByDefault: true,
},
{
Expand Down

0 comments on commit 08c1871

Please sign in to comment.