Rename the non-exposed field "count" to "size"

traefik · Jan 7, 2020 · 377c219 · 377c219
1 parent da3d814
commit 377c219
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/pkg/middlewares/accesslog/capture_request_reader.go b/pkg/middlewares/accesslog/capture_request_reader.go
@@ -3,8 +3,10 @@ package accesslog
 import "io"
 
 type captureRequestReader struct {
+	// source ReadCloser from where the request body is read.
 	source io.ReadCloser
-	count  int64
+	// count Counts the number of bytes read (when captureRequestReader.Read is called).
+	count int64
 }
 
 func (r *captureRequestReader) Read(p []byte) (int, error) {

diff --git a/pkg/middlewares/accesslog/logdata.go b/pkg/middlewares/accesslog/logdata.go
@@ -129,5 +129,6 @@ type downstreamResponse struct {
 
 type request struct {
 	headers http.Header
-	count   int64
+	// Request body size
+	size int64
 }
diff --git a/pkg/middlewares/accesslog/logger.go b/pkg/middlewares/accesslog/logger.go
@@ -214,7 +214,7 @@ func (h *Handler) ServeHTTP(rw http.ResponseWriter, req *http.Request, next http
 		size:    crw.Size(),
 	}
 	if crr != nil {
-		logDataTable.Request.count = crr.count
+		logDataTable.Request.size = crr.count
 	}
 
 	if h.config.BufferingSize > 0 {
@@ -280,7 +280,7 @@ func (h *Handler) logTheRoundTrip(logDataTable *LogData) {
 		retryAttempts = 0
 	}
 	core[RetryAttempts] = retryAttempts
-	core[RequestContentSize] = logDataTable.Request.count
+	core[RequestContentSize] = logDataTable.Request.size
 
 	status := logDataTable.DownstreamResponse.status
 	core[DownstreamStatus] = status