Skip to content

Commit

Permalink
Add Recover tests
Browse files Browse the repository at this point in the history
  • Loading branch information
emilevauge committed May 15, 2017
1 parent 111251d commit 48a91d0
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 1 deletion.
3 changes: 2 additions & 1 deletion middlewares/recover.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package middlewares

import (
"net/http"

"github.com/codegangsta/negroni"
"github.com/containous/traefik/log"
"net/http"
)

// RecoverHandler recovers from a panic in http handlers
Expand Down
45 changes: 45 additions & 0 deletions middlewares/recover_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
package middlewares

import (
"net/http"
"net/http/httptest"
"testing"

"github.com/codegangsta/negroni"
)

func TestRecoverHandler(t *testing.T) {
fn := func(w http.ResponseWriter, r *http.Request) {
panic("I love panicing!")
}
recoverHandler := RecoverHandler(http.HandlerFunc(fn))
server := httptest.NewServer(recoverHandler)
defer server.Close()

resp, err := http.Get(server.URL)
if err != nil {
t.Fatal(err)
}
if resp.StatusCode != http.StatusInternalServerError {
t.Fatalf("Received non-%d response: %d\n", http.StatusInternalServerError, resp.StatusCode)
}
}

func TestNegroniRecoverHandler(t *testing.T) {
n := negroni.New()
n.Use(NegroniRecoverHandler())
panicHandler := func(w http.ResponseWriter, r *http.Request, next http.HandlerFunc) {
panic("I love panicing!")
}
n.UseFunc(negroni.HandlerFunc(panicHandler))
server := httptest.NewServer(n)
defer server.Close()

resp, err := http.Get(server.URL)
if err != nil {
t.Fatal(err)
}
if resp.StatusCode != http.StatusInternalServerError {
t.Fatalf("Received non-%d response: %d\n", http.StatusInternalServerError, resp.StatusCode)
}
}

0 comments on commit 48a91d0

Please sign in to comment.