review

traefik · Jun 9, 2023 · 62d3781 · 62d3781
1 parent a165b22
commit 62d3781
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/integration/fixtures/simple_encode_semicolons.toml b/integration/fixtures/simple_encode_semicolons.toml
@@ -24,8 +24,7 @@
 [http.routers]
   [http.routers.router]
     service = "service1"
-    rule = "PathPrefix(`/`)"
-#    rule = "Host(`other.localhost`)"
+    rule = "Host(`other.localhost`)"
 
 [http.services]
   [http.services.service1.loadBalancer]

diff --git a/integration/simple_test.go b/integration/simple_test.go
@@ -1444,14 +1444,14 @@ func (s *SimpleSuite) TestEncodeSemicolons(c *check.C) {
 		expected int
 	}{
 		{
-			desc:     "!Query with semicolon, match",
+			desc:     "Transforming semicolons",
 			request:  "GET /?bar=toto;boo=titi HTTP/1.1\r\nHost: other.localhost\r\n\r\n",
 			target:   "127.0.0.1:8000",
 			expected: http.StatusOK,
 			body:     "bar=toto&boo=titi",
 		},
 		{
-			desc:     "!Query with semicolon, encode",
+			desc:     "Encoding semicolons",
 			request:  "GET /?bar=toto&boo=titi;aaaa HTTP/1.1\r\nHost: other.localhost\r\n\r\n",
 			target:   "127.0.0.1:8001",
 			expected: http.StatusOK,