Skip to content

Commit

Permalink
Minor Health UI fixes
Browse files Browse the repository at this point in the history
- format the Oy axis ticks as integers on the Total Status Code
Count chart
- prevent the Average Response Time chart from showing negative
values on the Oy axis
- remove the deprecated transitionDuration field
- set the transition duration to 0 on the Average Response Time
chart to avoid triggering an NVD3 marker placement bug
  • Loading branch information
mihaitodor authored and ldez committed Jun 6, 2017
1 parent a9216e2 commit 7874ffd
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions webui/src/app/sections/health/health.controller.js
Expand Up @@ -32,9 +32,9 @@ function HealthController($scope, $interval, $log, Health) {
valueFormat: function (d) {
return d3.format('d')(d);
},
transitionDuration: 50,
yAxis: {
axisLabelDistance: 30
axisLabelDistance: 30,
tickFormat: d3.format('d')
}
},
"title": {
Expand Down Expand Up @@ -95,7 +95,6 @@ function HealthController($scope, $interval, $log, Health) {
bottom: 40,
left: 55
},
transitionDuration: 50,
x: function (d) {
return d.x;
},
Expand All @@ -112,7 +111,10 @@ function HealthController($scope, $interval, $log, Health) {
tickFormat: function (d) {
return d3.format(',.1f')(d);
}
}
},
forceY: [0., 1.], // This prevents the chart from showing -1 on Oy when all the input data points
// have y = 0. It won't disable the automatic adjustment of the max value.
duration: 0 // Bug: Markers will not be drawn if you set this to some other value...
},
"title": {
"enable": true,
Expand Down

0 comments on commit 7874ffd

Please sign in to comment.