Skip to content

Commit

Permalink
Fix Docker provider mem leak on operation retries
Browse files Browse the repository at this point in the history
Co-authored-by: Mathieu Lonjaret <mathieu.lonjaret@gmail.com>
  • Loading branch information
rtribotte and mpl committed Aug 31, 2022
1 parent adf82d7 commit d3e4d56
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/provider/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ func (p *Provider) Provide(configurationChan chan<- dynamic.Message, pool *safe.
logger.Errorf("Failed to create a client for docker, error: %s", err)
return err
}
defer dockerClient.Close()

serverVersion, err := dockerClient.ServerVersion(ctx)
if err != nil {
Expand Down Expand Up @@ -249,7 +250,7 @@ func (p *Provider) Provide(configurationChan chan<- dynamic.Message, pool *safe.
case <-ticker.C:
services, err := p.listServices(ctx, dockerClient)
if err != nil {
logger.Errorf("Failed to list services for docker, error %s", err)
logger.Errorf("Failed to list services for docker swarm mode, error %s", err)
errChan <- err
return
}
Expand Down

0 comments on commit d3e4d56

Please sign in to comment.