Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow traefik.port to not be in the list of marathon ports #1394

Merged
merged 1 commit into from Apr 6, 2017
Merged

Allow traefik.port to not be in the list of marathon ports #1394

merged 1 commit into from Apr 6, 2017

Conversation

emilevauge
Copy link
Member

This PR supersedes #1309.
Fixes #261
Original author: @nicgrayson

@emilevauge emilevauge mentioned this pull request Apr 6, 2017
Closed
timoreimann
timoreimann approved these changes Apr 6, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nothing was changed from the original PR: LGTM. :-)

@emilevauge emilevauge merged commit 08c1871 into master Apr 6, 2017
@timoreimann timoreimann deleted the nicgrayson-master branch April 6, 2017 19:05
@timoreimann timoreimann mentioned this pull request Apr 6, 2017
Closed
This was referenced Apr 19, 2017
Closed
Merged
@ldez ldez added this to the 1.3 milestone May 19, 2017
@ldez ldez added kind/enhancement a new or improved feature. and removed status/3-needs-merge labels May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

Assignees
No one assigned
Labels
area/provider/marathon kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilevauge @timoreimann @ldez