Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin B3 headers Spanid/Traceid occasionally is 15 instead 16 digits long, zipkin-go-opentracing library needs update #4712

Closed
1 of 2 tasks
MaxWinterstein opened this issue Apr 2, 2019 · 1 comment
Labels
area/middleware/tracing kind/bug/confirmed a confirmed bug (reproducible). priority/P1 need to be fixed in next release status/5-frozen-due-to-age
Milestone

Comments

@MaxWinterstein
Copy link

Do you want to request a feature or report a bug?

Bug

Did you try using a 1.7.x configuration for the version 2.0?

  • Yes
  • No

What did you do?

When using zipkin tracing there are B3 headers added. But, sometimes they are missing one digit.
This has already been fixed openzipkin-contrib/zipkin-go-opentracing#98 but this is not working for 1.7.10.

I guess, somewhere the build pipeline needs some push to pull the master branch again or something?

What did you expect to see?

A 16 digit Spanid
"request_X-B3-Spanid":"03b7e31b3c6e4b4b" <-- Note the 0

What did you see instead?

A 15 digit Spanid
"request_X-B3-Spanid":"3b7e31b3c6e4b4b"

Output of traefik version: (What version of Traefik are you using?)

1.7.10-alpine (docker image)

Version:      v1.7.10
Codename:     maroilles
Go version:   go1.11.6
Built:        2019-03-29_12:20:34PM
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?

    [tracing]
      backend = "zipkin"
      serviceName = "traefik"
      [tracing.zipkin]
        httpEndpoint = "http://XXX"
        debug = true
        sameSpan = false
        id128bit = true
@MaxWinterstein MaxWinterstein changed the title zipkin B3 headers Spanid/Traceid occasionally is 15 instead 16 digits long, library needs update zipkin B3 headers Spanid/Traceid occasionally is 15 instead 16 digits long, zipkin-go-opentracing library needs update Apr 2, 2019
@emilevauge emilevauge added area/middleware/tracing kind/bug/confirmed a confirmed bug (reproducible). priority/P1 need to be fixed in next release and removed status/0-needs-triage labels Apr 3, 2019
@traefiker traefiker added this to the 1.7 milestone Apr 5, 2019
@traefiker
Copy link
Contributor

Closed by #4720.

@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/middleware/tracing kind/bug/confirmed a confirmed bug (reproducible). priority/P1 need to be fixed in next release status/5-frozen-due-to-age
Projects
None yet
Development

No branches or pull requests

3 participants