Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tracing dependencies #4721

Merged
merged 3 commits into from Apr 5, 2019
Merged

Update tracing dependencies #4721

merged 3 commits into from Apr 5, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 4, 2019

What does this PR do?

Update tracing dependencies:

  • github.com/openzipkin-contrib/zipkin-go-opentracing
  • github.com/uber/jaeger-client-go
  • github.com/apache/thrift
  • github.com/uber/jaeger-lib
  • github.com/opentracing/opentracing-go

Motivation

Be up-to-date

Related to #4712

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Apr 4, 2019
@ldez ldez added this to To review in v2 via automation Apr 4, 2019
juliens
juliens approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ed12366 into traefik:v2.0 Apr 5, 2019
v2 automation moved this from To review to Done Apr 5, 2019
@ldez ldez deleted the feature/update-zipkin branch April 5, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/middleware/tracing kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @dtomcej @traefiker