-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpages not rendering completly when using error pages #5385
Comments
This comment has been minimized.
This comment has been minimized.
I don't think this is a configuration problem since it's not happening on previous version |
Hello, There is no change in the code on this subject. You can check by yourself: v1.7.14...v1.7.16 |
Could you provide your whole configuration (traefik.toml, docker-compose, ...) |
Removing the custom error page fix the problem:
|
Could you provide a minimal reproducible case? |
This comment has been minimized.
This comment has been minimized.
@Leosirth I cannot reproduce for now, even with error pages enabled. Do you see any errors in the chrome developper tools console? |
@Leosirth Could you provide your whole configuration (traefik.toml, docker-compose, ...) and/or a minimal reproducible case? |
I made some more test and I can see that Firefox 70.0b6 (64-bit) and IE 11.356.18362.0 are the ones more affected, nearly all the backends with custom error pages suffer this issue. Going to Chrome 77.0.3865.75 I can reproduce the issue consistently with only one backend: nodered I can't see any relevant on browser console, sometimes the site doesn't load at all without anything logged in console, sometimes it is partially loaded and I can see the following:
I have also a grafana and huginn backends for which I'm unable to login (with every browser) getting an error 500 from traefik, but I can see that the request never reach the beackend, I can see the following in the traefik log for this (looks similar on the issue #5376 but I'm on 1.7.16): traefik.log
Regarding my configuration please find below: traefik.toml
I don't have a docker-compose to share, but nothing special configured on the containers.
|
Before this change, the codeCatcher relied on the fact that Write would always be called, and hence was in charge of actually sending the headers that WriteHeader had "cached" when it had been called. However, in the case of e.g. a 304, since the response should not have any body, there is no reason for the caller (i.e. another proxy or middleware in the chain of calls) to call the codeCatcher's Write. Therefore, neither the headers, and hence nor the the response code, were actually forwarded to the client. Consequently, this change moves the responsibility of actually forwarding the headers and response code to where it belongs, i.e. in WriteHeader. In addition, this change adds a wrapper of the codeCatcher, so that we can satisfy the CloseNotify interface as well. Fixes traefik#5385
Closed by #5404. |
Do you want to request a feature or report a bug?
Bug
Did you try using a 1.7.x configuration for the version 2.0?
What did you do?
Updated traefik from 1.7.14 to 1.7.16
What did you expect to see?
Correct loading of web pages
What did you see instead?
When loading webpages through traefik not all objects are rendered, i.e. images or CSS.
i.e. getting heimdall, sometimes images are missing:
hitting F5 get different behaviour, but always not rendering everything:
But hitting CTRL+F5 in order to force a full refresh from website get a correct render of the page.
This is happening with all the backends (heimdall is only an example) and with every web browsers.
Going back to version 1.7.14 fix the issue.
This is happening also with version 1.7.15
Output of
traefik version
: (What version of Traefik are you using?)If applicable, please paste the log output in DEBUG level (
--log.level=DEBUG
switch)I can't spot any differences on the logs, let me know what would be needed since I need to clean from personal data.
The text was updated successfully, but these errors were encountered: