Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping resulting in 503 http code during graceful shutdown #6688

Closed
L3o-pold opened this issue Apr 16, 2020 · 2 comments
Closed

Ping resulting in 503 http code during graceful shutdown #6688

L3o-pold opened this issue Apr 16, 2020 · 2 comments
Assignees
Labels
area/provider/k8s kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future status/5-frozen-due-to-age
Projects
Milestone

Comments

@L3o-pold
Copy link
Contributor

L3o-pold commented Apr 16, 2020

Do you want to request a feature or report a bug?

Bug

What did you do?

Request shutdown of traefik and wait for a livenessProbe check.

It's well documented in the 1.7 doc but not in the 2.x.

When used in a livenessProbe in k8s an 503 http code is seen as an error.

What did you expect to see?

200 on ping request

What did you see instead?

503 on ping request

Output of traefik version: (What version of Traefik are you using?)

2.1.3

What is your environment & configuration (arguments, toml, provider, platform, ...)?

[ping]
  entryPoint = "ping"
[api]
  dashboard = true

[entryPoints]
  [entryPoints.ping]
    address = ":8081"
    [entryPoints.ping.transport]
      [entryPoints.ping.transport.lifeCycle]
        requestAcceptGraceTimeout = "60s"
        graceTimeOut = "2h"

Kubernetes example:

livenessProbe:
  httpGet:
    path: /ping
    port: 8081
    scheme: HTTP
  initialDelaySeconds: 10
  timeoutSeconds: 2 

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)

time="2020-04-16T14:10:56Z" level=error msg="close tcp [::]:80: use of closed network connection" entryPointName=http
time="2020-04-16T14:10:56Z" level=error msg="close tcp [::]:8080: use of closed network connection" entryPointName=traefik
time="2020-04-16T14:10:56Z" level=error msg="accept tcp [::]:8080: use of closed network connection" entryPointName=traefik
time="2020-04-16T14:10:56Z" level=error msg="accept tcp [::]:80: use of closed network connection" entryPointName=http
[16/Apr/2020:14:11:00 +0000] "GET /ping HTTP/1.1" 503 19 "-" "-" 18 "ping@internal" - 0ms
[16/Apr/2020:14:11:14 +0000] "GET /ping HTTP/1.1" 503 19 "-" "-" 21 "ping@internal" - 0ms

I don't think that's really a bug since it's documented in 1.7.x but an 503 http code is not really great IMO. Maybe we can add an option in the configuration for this to avoid breaking change.

@traefiker

This comment has been minimized.

@ldez ldez added area/provider/k8s kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed. priority/P1 need to be fixed in next release and removed status/0-needs-triage labels Apr 17, 2020
@mpl mpl added kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future and removed kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed. priority/P1 need to be fixed in next release labels Jun 15, 2020
@L3o-pold
Copy link
Contributor Author

@ldez ldez added this to issues in v2 via automation Aug 11, 2020
@ldez ldez added this to the 2.3 milestone Aug 11, 2020
@traefik traefik locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/provider/k8s kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future status/5-frozen-due-to-age
Projects
No open projects
v2
issues
Development

No branches or pull requests

5 participants