Add custom ping http code when Traefik is terminating #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3o-pold
force-pushed
the
add_custom_ping_termination_status_code
branch
from
faadf6c
to
30c8143
Compare
ldez
added
area/api
kind/enhancement
dtomcej
previously requested changes
May 28, 2020
L3o-pold
force-pushed
the
add_custom_ping_termination_status_code
branch
3 times, most recently
from
a7b2b32
to
f34ea18
Compare
SantoDE
added
status/2-needs-review
and removed
contributor/waiting-for-corrections
status/1-needs-design-review
labels
mpl
approved these changes
Jun 22, 2020
traefiker
force-pushed
the
add_custom_ping_termination_status_code
branch
from
1ccf09f
to
d19c1cf
Compare
ldez
added
contributor/waiting-for-corrections
status/2-needs-review
and removed
bot/need-human-merge
status/3-needs-merge
labels
jbdoumenjou
force-pushed
the
add_custom_ping_termination_status_code
branch
from
d19c1cf
to
832a659
Compare
ldez
added
status/3-needs-merge
and removed
contributor/waiting-for-corrections
status/2-needs-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow custom http code in ping route when Traefik is terminating (graceful shutdown)
Motivation
Issue #6688
Better handling of graceful shutdown with Kubernetes livenessprobe.
More