Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic on resource backends #10023

Merged
merged 1 commit into from Jul 19, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 18, 2023

What does this PR do?

Returns an error instead of panic on the non-supported resource backends.

Motivation

Avoid panic on resource backends with Ingress.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Related to #10022

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bed6069 into traefik:v2.10 Jul 19, 2023
9 checks passed
v2 automation moved this from To review to Done Jul 19, 2023
@ldez ldez deleted the fix/resource-backends branch July 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants