Ignore ErrKeyNotFound error for the KV provider #10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Hello, your PR doesn't target the right branch, can you rebase your PR on the branch v2.10? can you also remove all the unrelated changes? |
ldez
added
contributor/waiting-for-corrections
area/provider/kv
area/provider/redis
kind/bug/fix
|
Okay, I will remove the second change. However, for the first one, I moved the setupStore function to SetUpSuite and the cleanup action to TearDownSuite, which is executed by the go-checker. This means we don't need to care about setting and cleaning some common things in every testcase. Are you sure I should remove it? |
yes |
rtribotte
force-pushed
the
issue-8092
branch
from
2c6624c
to
92ffb74
Compare
kevinpollet
changed the title
kevinpollet
changed the title
traefiker
force-pushed
the
issue-8092
branch
from
92ffb74
to
aae182a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8092
Motivation
When the root key does not exist, listing the kv store will result in an 'ErrKeyNotFound' error. In this case, the kv provider will not send a dynamic.Message to the configurationChan for updating the configuration. So when we delete the root key in the kv store to clear all traefik configurations, traefik will always retain the last configuration.
More
[ ] Added/updated documentationAdditional Notes
While fixing this bug, I encountered another potential bug caused by the kvtools/redis library when using Redis as the kv store. The kv provider utilizes the WatchTree interface to monitor events of key changes in the kv store. However, when we delete the root key in Redis, the WatchTree fails to notify the kv provider about the modification of certain keys. Therefore, even though I have fixed the buildConfiguration function of the kv provider, this bug may still persist when Redis is used as the kv store. About the bug of kvtools/redis , I have created an issue: kvtools/redis#4