Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code usage for datadog tracer #10196

Merged
merged 1 commit into from Oct 27, 2023
Merged

Remove deprecated code usage for datadog tracer #10196

merged 1 commit into from Oct 27, 2023

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Oct 26, 2023

What does this PR do?

Fix the deprecated method used on the datadog tracer

Motivation

Fixes #10188

More

  • Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

@mmatur mmatur added this to the 2.10 milestone Oct 26, 2023
rtribotte
rtribotte approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

ldez
ldez approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L.G.T.M.

kevinpollet
kevinpollet approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 679975b into traefik:v2.10 Oct 27, 2023
9 checks passed
@traefiker traefiker mentioned this pull request Oct 27, 2023
Closed
2 tasks
@rtribotte rtribotte changed the title fix: datadog tracer Remove deprecated code usage for datadog tracer Nov 28, 2023
@mmatur mmatur deleted the fix/datadogtrace branch January 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/middleware/tracing kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmatur @kevinpollet @ldez @rtribotte @traefiker