-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to opentelemetry #10223
Merged
Merged
Migrate to opentelemetry #10223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetaab
force-pushed
the
feat/updateopentelemetry
branch
5 times, most recently
from
November 10, 2023 08:34
aa238c2
to
fd73009
Compare
zetaab
force-pushed
the
feat/updateopentelemetry
branch
2 times, most recently
from
November 10, 2023 10:06
7ca5470
to
9c3fc97
Compare
this also fixes #10210 it adds user-agent information as attribute |
2 tasks
zetaab
force-pushed
the
feat/updateopentelemetry
branch
12 times, most recently
from
November 11, 2023 13:38
2129819
to
78dfee4
Compare
Co-authored-by: sven <sven@leftxs.org>
Co-authored-by: sven <sven@leftxs.org>
rtribotte
force-pushed
the
feat/updateopentelemetry
branch
from
January 5, 2024 16:13
4016ca8
to
b682c50
Compare
rtribotte
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
2 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates from opentracing to opentelemetry
fixes #9762
fixes #10210
fixes #10235
More
Additional Notes
only opentelemetry is verified. I do not have datadog/elastic/instana/zipkin setup, so I cannot verify these. Also integration tests are interesting, not sure either is everything there that should be.
tl;dr changes:
datadog
prioritySampling
setting. It is not supported anymore in opentelemetry(?)elastic
globalTags
andsampleRate
settingshaystack
two reasons for that
instana
localAgentHost
settinglocalAgentPort
settinglogLevel
settingenableAutoProfile
settingglobalTags
andsampleRate
settingspeople need to use standard env variables
INSTANA_ENDPOINT_URL
&INSTANA_AGENT_KEY
to configure instana.jaeger
opentelemetry
globalTags
andsampleRate
settingszipkin
sameSpan
settingid128Bit
settingglobalTags
setting