Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to opentelemetry #10223

Merged
merged 32 commits into from
Jan 8, 2024
Merged

Conversation

zetaab
Copy link
Contributor

@zetaab zetaab commented Nov 9, 2023

What does this PR do?

Migrates from opentracing to opentelemetry

fixes #9762
fixes #10210
fixes #10235

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

only opentelemetry is verified. I do not have datadog/elastic/instana/zipkin setup, so I cannot verify these. Also integration tests are interesting, not sure either is everything there that should be.

tl;dr changes:

datadog

  • removed prioritySampling setting. It is not supported anymore in opentelemetry(?)

elastic

  • added globalTags and sampleRate settings

haystack

  • removed support for haystack.

two reasons for that

  1. it was using github.com/ExpediaDotCom/haystack-client-go which is last time updated 4-5 years ago. There is no sense to maintain provider that have library that are not maintained. It can cause security issues to Traefik itself.
  2. there is no opentelemetry library for haystack

instana

  • removed localAgentHost setting
  • removed localAgentPort setting
  • removed logLevel setting
  • removed enableAutoProfile setting
  • added globalTags and sampleRate settings

people need to use standard env variables INSTANA_ENDPOINT_URL & INSTANA_AGENT_KEY to configure instana.

jaeger

  • removed support for jaeger, as their documentation states please us opentelemetry instead.

opentelemetry

  • added globalTags and sampleRate settings

zipkin

  • removed sameSpan setting
  • removed id128Bit setting
  • added globalTags setting

@traefiker traefiker added this to the 3.0 milestone Nov 9, 2023
@ldez ldez marked this pull request as draft November 9, 2023 15:04
@ldez ldez changed the title wip: migrate to opentelemetry Migrate to opentelemetry Nov 9, 2023
@zetaab zetaab force-pushed the feat/updateopentelemetry branch 5 times, most recently from aa238c2 to fd73009 Compare November 10, 2023 08:34
@zetaab zetaab marked this pull request as ready for review November 10, 2023 08:40
@zetaab zetaab force-pushed the feat/updateopentelemetry branch 2 times, most recently from 7ca5470 to 9c3fc97 Compare November 10, 2023 10:06
@zetaab
Copy link
Contributor Author

zetaab commented Nov 10, 2023

this also fixes #10210 it adds user-agent information as attribute

@zetaab zetaab force-pushed the feat/updateopentelemetry branch 12 times, most recently from 2129819 to 78dfee4 Compare November 11, 2023 13:38
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants