Refuse recursive requests (CVE-2023-47633) #10242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
force-pushed
the
refuse-recursive-requests
branch
from
6d9946f
to
e07ac69
Compare
ldez
requested changes
Nov 15, 2023
juliens
reviewed
Nov 16, 2023
lbenguigui
reviewed
Nov 17, 2023
lbenguigui
reviewed
Nov 17, 2023
kevinpollet
requested changes
Nov 17, 2023
lbenguigui
reviewed
Nov 20, 2023
ldez
requested changes
Nov 20, 2023
pkg/middlewares/denyrouterrecursion/deny_router_recursion_test.go
Outdated
Show resolved
Hide resolved
pkg/middlewares/denyrouterrecursion/deny_router_recursion_test.go
Outdated
Show resolved
Hide resolved
pkg/middlewares/denyrouterrecursion/deny_router_recursion_test.go
Outdated
Show resolved
Hide resolved
pkg/middlewares/denyrouterrecursion/deny_router_recursion_test.go
Outdated
Show resolved
Hide resolved
rtribotte
commented
Nov 21, 2023
ldez
approved these changes
Nov 21, 2023
Co-authored-by: Landry Benguigui <lbenguigui@gmail.com>
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
traefiker
force-pushed
the
refuse-recursive-requests
branch
from
bea4e99
to
f98f1cf
Compare
nmengin
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an internal middleware that is automatically appended to the default rule's routers, to stop request recursion on Traefik.
Motivation
The exposure of the Traefik container combined with the default rule mechanism can lead to create a router targeting itself in a loop.
In this case, to prevent an infinite loop, Traefik adds an internal middleware to refuse the request if already been passed by the same router.
More
Additional Notes
Co-authored-by: Michael michael.matur@gmail.com