Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Concepts documentation page #10315

Merged
merged 2 commits into from Jan 10, 2024
Merged

Conversation

oliver-dvorski
Copy link
Contributor

"it means" -> "this means"

What does this PR do?

Slightly rewords the documentation, making it easier to read and follow.

Motivation

I was reading the docs and noticed this error.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@rtribotte
Copy link
Member

rtribotte commented Dec 26, 2023

Hello @oliver-dvorski,

Thank you for this contribution!

Can you please rebase this PR on the v2.11 branch?

@mmatur mmatur self-assigned this Jan 8, 2024
@ldez ldez changed the title Update concepts.md docs: slightly rewords the documentation Jan 8, 2024
@mmatur mmatur changed the base branch from master to v2.11 January 9, 2024 08:59
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur removed their assignment Jan 9, 2024
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

oliver-dvorski and others added 2 commits January 10, 2024 09:46
"it means" -> "this means"
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
@traefiker traefiker merged commit e78374a into traefik:v2.11 Jan 10, 2024
22 checks passed
v2 automation moved this from To review to Done Jan 10, 2024
@oliver-dvorski oliver-dvorski deleted the patch-1 branch January 10, 2024 14:21
@rtribotte rtribotte changed the title docs: slightly rewords the documentation Improve Concepts documentation page Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants