Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Nomad API dependency to v1.7.2 #10327

Merged
merged 3 commits into from Jan 12, 2024

Conversation

jrasell
Copy link
Contributor

@jrasell jrasell commented Jan 3, 2024

What does this PR do?

Update the Nomad API dependency to v1.7.2.

Motivation

Along with some minor fixes, this new version of the Nomad API package adds support for connectivity via UNIX domain sockets. When Traefik is being run as a Nomad job, this change will allow operators to use the socket that Nomad automatically injects into the task namespace for API connectivity.

I have targeted the v3.0 branch as I don't feel this modification falls under the bug fix category, as detailed in your contributing guide. Please let me know if there are any questions or problems.

@traefiker traefiker added this to the 3.0 milestone Jan 3, 2024
@nmengin nmengin self-assigned this Jan 4, 2024
@nmengin
Copy link
Contributor

nmengin commented Jan 4, 2024

Hello @jrasell,

Thank you for your contribution.
After discussing it with other maintainers, we think that your PR can be brought in Traefik v2.11.
To do so, could you rebase your branch on v2.11?

@jrasell jrasell changed the base branch from v3.0 to v2.11 January 5, 2024 09:15
@jrasell
Copy link
Contributor Author

jrasell commented Jan 5, 2024

Hello @jrasell,

Thank you for your contribution. After discussing it with other maintainers, we think that your PR can be brought in Traefik v2.11. To do so, could you rebase your branch on v2.11?

Hi @nmengin and thanks for taking a look. I have updated the base branch to v2.11 as requested and modified the PR target branch to match.

@kevinpollet kevinpollet changed the title deps: Update the Nomad API dependency to v1.7.2 deps: update the Nomad API dependency to v1.7.2 Jan 5, 2024
@kevinpollet kevinpollet closed this Jan 5, 2024
@kevinpollet kevinpollet reopened this Jan 5, 2024
@nmengin
Copy link
Contributor

nmengin commented Jan 5, 2024

Thank you @jrasell.

We closed and re-opened the PR to fix a CI issue.
We review it as soon as the checks are done.

@kevinpollet kevinpollet added the kind/bug/fix a bug fix label Jan 10, 2024
@kevinpollet
Copy link
Member

Hello @jrasell,

Could you fix the conflicts?

@jrasell
Copy link
Contributor Author

jrasell commented Jan 10, 2024

Hello @jrasell,

Could you fix the conflicts?

Hi @kevinpollet, those have now been fixed.

@kevinpollet kevinpollet added this to To review in v2 via automation Jan 12, 2024
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jrasell 👍

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3a461d2 into traefik:v2.11 Jan 12, 2024
22 checks passed
v2 automation moved this from To review to Done Jan 12, 2024
@jrasell jrasell deleted the f-nomad-api-dep-1.7.2 branch January 12, 2024 19:03
@rtribotte rtribotte changed the title deps: update the Nomad API dependency to v1.7.2 Update the Nomad API dependency to v1.7.2 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants