New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Nomad API dependency to v1.7.2 #10327
Conversation
Hello @jrasell, Thank you for your contribution. |
a06d7ac
to
2f07dad
Compare
Hi @nmengin and thanks for taking a look. I have updated the base branch to |
Thank you @jrasell. We closed and re-opened the PR to fix a CI issue. |
Hello @jrasell, Could you fix the conflicts? |
Hi @kevinpollet, those have now been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jrasell 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Update the Nomad API dependency to v1.7.2.
Motivation
Along with some minor fixes, this new version of the Nomad API package adds support for connectivity via UNIX domain sockets. When Traefik is being run as a Nomad job, this change will allow operators to use the socket that Nomad automatically injects into the task namespace for API connectivity.
I have targeted the v3.0 branch as I don't feel this modification falls under the bug fix category, as detailed in your contributing guide. Please let me know if there are any questions or problems.