Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for cross-namespace references / GatewayAPI ReferenceGrants #10346

Merged
merged 14 commits into from Jan 30, 2024
Merged

Support for cross-namespace references / GatewayAPI ReferenceGrants #10346

merged 14 commits into from Jan 30, 2024

Conversation

pascal-hofmann
Copy link
Contributor

@pascal-hofmann pascal-hofmann commented Jan 11, 2024 •
edited

What does this PR do?

  • This adds support for cross-namespace references / GatewayAPI ReferenceGrants for Secrets.
  • It also fixes a lot of conformance issues that have been discovered while running Gateway API conformance tests.

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • Support for ReferenceGrants for Services (backendRefs) is not part of this PR.
  • I intentionally created separate commits to make it a bit easier to review.
  • The conformance tests that affect ReferenceGrants for Secrets should be covered, but I had to uncomment/disable a lot of things because Traefik is non-conformant in a lot of unrelated areas and some tests for ReferenceGrants check that other things work too.

@traefiker traefiker added this to the 3.0 milestone Jan 11, 2024
@pascal-hofmann pascal-hofmann force-pushed the feat/reference-grants-for-secrets branch 2 times, most recently from 6578251 to a611d36 Compare January 11, 2024 13:48
@pascal-hofmann
Copy link
Contributor Author

I’ll have a look at the failing validation job.

@pascal-hofmann pascal-hofmann force-pushed the feat/reference-grants-for-secrets branch 2 times, most recently from 8b5c14a to 63b56b2 Compare January 15, 2024 16:08
@pascal-hofmann
Copy link
Contributor Author

Validations are fixed now.

@nmengin nmengin added the priority/P2 need to be fixed in the future label Jan 16, 2024
@mmatur
Copy link
Member

mmatur commented Jan 16, 2024

Thanks @pascal-hofmann for your contribution.

I will take a look later this week.
FYI I will open a PR to integrate the Gateway API conformance test later this week, it will help us in the following deployment for Gateway API

@mmatur
Copy link
Member

mmatur commented Jan 17, 2024

@pascal-hofmann the PR regarding Gateway API conformance tests has been opened.

I could be great if you can have a look.

FYI: I'm starting my work on this PR

@mmatur mmatur force-pushed the feat/reference-grants-for-secrets branch 4 times, most recently from 4983f71 to 2a43901 Compare January 25, 2024 08:39
mmatur
mmatur approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur force-pushed the feat/reference-grants-for-secrets branch from 7dc7268 to 026535a Compare January 25, 2024 15:36
rtribotte
rtribotte approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

nmengin
nmengin approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👏

@traefiker traefiker force-pushed the feat/reference-grants-for-secrets branch from 7707afd to 37cca98 Compare January 30, 2024 15:06
pascal-hofmann and others added 14 commits January 30, 2024 15:30
@pascal-hofmann @traefiker
feat(gateway-api): Support cross-namespace secret references via Refe…
2d259b8 
…renceGrants
@pascal-hofmann @traefiker
fix(gateway-api): Don't ignore condition updates for newer observed g…
246edac 
…enerations
@pascal-hofmann @traefiker
fix(gateway-api): Properly handle updates to GatewayClass resources
c866a2c
@pascal-hofmann @traefiker
fix(gateway-api): Set SupportedKinds according to Gateway API specifi…
ad17754 
…cation
@pascal-hofmann @traefiker
fix(gateway-api): Avoid showing pointers in condition messages
89fe6a0
@pascal-hofmann @traefiker
fix(gateway-api): Also set listener status if there are invalid liste…
f634707 
…ners
@pascal-hofmann @traefiker
fix(gateway-api): Set conditions according to Gateway API spec
6645dbd
@pascal-hofmann @traefiker
chore: Fix formatting
0c9cccf
@mmatur @traefiker
feat: enable reference grants tests for gateway api conformance
b645150
@mmatur @traefiker
fix: rulesyntax in gateway unit test
9c5070a
@mmatur @traefiker
fix make validate
bf34a6f
@mmatur @traefiker
fix for review
95a4b2a
@mmatur @traefiker
fix: revert change about slice in gateway api
0b0e90c
@rtribotte @traefiker
review
1a2828d
@traefiker traefiker force-pushed the feat/reference-grants-for-secrets branch from 37cca98 to 1a2828d Compare January 30, 2024 15:30
@traefiker traefiker merged commit 9be523d into traefik:v3.0 Jan 30, 2024
23 checks passed
@mmatur mmatur mentioned this pull request Jan 30, 2024
Closed
2 tasks
@mmatur mmatur removed their assignment Jan 30, 2024
@pascal-hofmann pascal-hofmann deleted the feat/reference-grants-for-secrets branch January 30, 2024 16:52
@pascal-hofmann
Copy link
Contributor Author

Hi,

thanks for the quick merge. 🚀

Is there a timeline for a new v3 beta release containing this new feature?

Cheers
Pascal

@nmengin
Copy link
Contributor

nmengin commented Mar 6, 2024

Hey @pascal-hofmann,

Sorry for the delay.
I don't know if you have seen it but we have released Traefik v3.0.0-beta1 that embeds this feature.

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/gatewayapi area/provider/k8s kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future size/L
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pascal-hofmann @mmatur @nmengin @rtribotte @traefiker