Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce static config hints #10351

Merged
merged 15 commits into from Jan 23, 2024

Conversation

rtribotte
Copy link
Member

What does this PR do?

This PR introduces a mechanism to handle unknown fields in static configuration and print hints for mitigation in case of migration.

Motivation

To ease v2 to v3 migration.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io

@rtribotte rtribotte added this to the 3.0 milestone Jan 15, 2024
@rtribotte rtribotte marked this pull request as ready for review January 15, 2024 09:50
@rtribotte rtribotte force-pushed the static-config-deprecation-hints branch from 18018eb to 7fc379c Compare January 15, 2024 10:24
@nmengin nmengin added the priority/P1 need to be fixed in next release label Jan 15, 2024
@jspdown jspdown self-requested a review January 15, 2024 13:34
@juliens juliens self-requested a review January 15, 2024 13:35
@lbenguigui lbenguigui requested review from lbenguigui and removed request for juliens January 15, 2024 13:35
@rtribotte rtribotte marked this pull request as draft January 15, 2024 16:32
@rtribotte rtribotte force-pushed the static-config-deprecation-hints branch from 367559f to 206ae08 Compare January 18, 2024 10:51
@rtribotte rtribotte marked this pull request as ready for review January 18, 2024 16:42
pkg/cli/deprecation.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

A few suggestions after a first review.

pkg/cli/deprecation.go Outdated Show resolved Hide resolved
pkg/cli/deprecation.go Outdated Show resolved Hide resolved
pkg/cli/deprecation.go Outdated Show resolved Hide resolved
pkg/cli/deprecation.go Outdated Show resolved Hide resolved
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rtribotte and others added 7 commits January 22, 2024 18:45
Co-authored-by: Michael <mmatur@users.noreply.github.com>
Co-authored-by: Nicolas Mengin <nmengin.pro@gmail.com>
@mmatur mmatur force-pushed the static-config-deprecation-hints branch from a328fa6 to f97f75d Compare January 22, 2024 17:45
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f9831f5 into traefik:v3.0 Jan 23, 2024
22 checks passed
@rtribotte rtribotte deleted the static-config-deprecation-hints branch March 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs kind/enhancement a new or improved feature. priority/P1 need to be fixed in next release size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants