-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semconv OTLP stable HTTP metrics #10421
Conversation
Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmh 🤔, there is also a convention on GRPC metrics.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/grpc.md
I suggest to either precise this in PR title or cover the GRPC part.
The gRPC semantic convention are still experimental, we are handling only stable metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9352162
to
add38bd
Compare
decb997
to
80bf26b
Compare
80bf26b
to
9f14d37
Compare
What does this PR do?
Add semconv otlp metrics
Only the two stable metrics are added:
http.server.request.duration
http.client.request.duration
Semantic convention document is available here
Motivation
Fixes: #10219
More
Additional Notes
Co-authored-by: Romain rtribotte@users.noreply.github.com
Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io