Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semconv OTLP stable HTTP metrics #10421

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Feb 9, 2024

What does this PR do?

Add semconv otlp metrics

Only the two stable metrics are added:

  • http.server.request.duration
  • http.client.request.duration

Semantic convention document is available here

Motivation

Fixes: #10219

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Romain rtribotte@users.noreply.github.com
Co-authored-by: Baptiste Mayelle baptiste.mayelle@traefik.io

@mmatur
Copy link
Member Author

mmatur commented Feb 9, 2024

Adding no-merge, we still have a panic on Tracing integration tests, I still have to investigate beginning of next week.

Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh 🤔, there is also a convention on GRPC metrics.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/grpc.md

I suggest to either precise this in PR title or cover the GRPC part.

@rtribotte rtribotte changed the title feat: semconv OTLP metrics feat: semconv OTLP HTTP metrics Feb 12, 2024
@rtribotte rtribotte changed the title feat: semconv OTLP HTTP metrics Semconv OTLP HTTP metrics Feb 12, 2024
@mmatur mmatur changed the title Semconv OTLP HTTP metrics Semconv OTLP stable HTTP metrics Feb 12, 2024
@mmatur
Copy link
Member Author

mmatur commented Feb 12, 2024

Mmmh 🤔, there is also a convention on GRPC metrics. https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/grpc.md

I suggest to either precise this in PR title or cover the GRPC part.

The gRPC semantic convention are still experimental, we are handling only stable metrics

@kevinpollet kevinpollet self-assigned this Feb 15, 2024
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/traefik/traefik.go Outdated Show resolved Hide resolved
docs/content/observability/metrics/overview.md Outdated Show resolved Hide resolved
docs/content/observability/metrics/overview.md Outdated Show resolved Hide resolved
docs/content/observability/metrics/overview.md Outdated Show resolved Hide resolved
docs/content/observability/metrics/overview.md Outdated Show resolved Hide resolved
pkg/metrics/opentelemetry.go Show resolved Hide resolved
pkg/server/service/observability_roundtripper.go Outdated Show resolved Hide resolved
pkg/server/service/observability_roundtripper.go Outdated Show resolved Hide resolved
pkg/metrics/opentelemetry.go Outdated Show resolved Hide resolved
@traefiker traefiker merged commit 6c9687f into traefik:v3.0 Mar 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/middleware/metrics area/middleware kind/enhancement a new or improved feature. priority/P1 need to be fixed in next release size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants