Make text more readable in dark mode #10473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hood, Thanks for the contribution. For such reason, could rebase it on the branch v2.11, please? |
mmatur
added
status/2-needs-review
contributor/waiting-for-corrections
and removed
status/0-needs-triage
labels
hood
force-pushed
the
more-legible-dark-text
branch
2 times, most recently
from
4d05802
to
2fb104a
Compare
hood
force-pushed
the
more-legible-dark-text
branch
from
2fb104a
to
b65e5e9
Compare
Sure, I’ve just rebased it. Let me know if I can do anything else to help. |
mmatur
added
kind/bug/fix
rtribotte
changed the title
nmengin
approved these changes
Mar 5, 2024
|
Hey @hood, Thank you for the contribution 👍 |
traefiker
force-pushed
the
more-legible-dark-text
branch
from
b65e5e9
to
8fc39da
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances the legibility of coloured text in dark mode in some places.
Motivation
Not all coloured labels are easily legible when using the dark mode UI version, significantly impacting its accessibility.
More
Additional Notes
Closes #9623
Preview:
Screen.Recording.2024-02-26.at.13.06.28.mov