Add correction about TCP_TLS routers in docs #10489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mathieu Lonjaret <mathieu.lonjaret@gmail.com>
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
Co-authored-by: Mathieu Lonjaret <mathieu.lonjaret@gmail.com> Co-authored-by: Tom Moulard <tom.moulard@traefik.io> Co-authored-by: Romain <rtribotte@users.noreply.github.com> Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
Co-authored-by: Michael Kuhnt <michael.kuhnt@daimler.com> Co-authored-by: Julien Salleyron <julien@containo.us> Co-authored-by: Mathieu Lonjaret <mathieu.lonjaret@gmail.com>
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
ldez
changed the title
rtribotte
added
area/documentation
kind/bug/fix
rtribotte
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Hello @shivanipawar00,
Thanks for opening this PR!
I have a few review comments.
Also, as a bug fix, this PR should target the v2.11 branch, could you please rebase the changes on it?
| @@ -870,7 +870,8 @@ The [supported `provider` table](../../https/acme.md#providers) indicates if the | |||
|
|
|||
| ### General | |||
|
|
|||
| If both HTTP routers and TCP routers listen to the same EntryPoint, the TCP routers will apply *before* the HTTP routers. | |||
| In case of non-TLS Entrypoint, both HTTP routers and TCP routers listen to the same EntryPoint, the TCP routers will apply *before* the HTTP routers. | |||
There was a problem hiding this comment.
Suggested change
| In case of non-TLS Entrypoint, both HTTP routers and TCP routers listen to the same EntryPoint, the TCP routers will apply *before* the HTTP routers. | |
| For non-TLS connections, if HTTP and TCP routers listen on the same EntryPoint, the TCP routers will apply *before* the HTTP routers. |
| @@ -870,7 +870,8 @@ The [supported `provider` table](../../https/acme.md#providers) indicates if the | |||
|
|
|||
| ### General | |||
|
|
|||
| If both HTTP routers and TCP routers listen to the same EntryPoint, the TCP routers will apply *before* the HTTP routers. | |||
| In case of non-TLS Entrypoint, both HTTP routers and TCP routers listen to the same EntryPoint, the TCP routers will apply *before* the HTTP routers. | |||
| In case of TLS Entrpoint, both HTTPS and TCP-TLS routers listen to the same EntryPoint, the HTTPS routers will apply *before* the TCP-TLS routers. | |||
There was a problem hiding this comment.
Suggested change
| In case of TLS Entrpoint, both HTTPS and TCP-TLS routers listen to the same EntryPoint, the HTTPS routers will apply *before* the TCP-TLS routers. | |
| For TLS connections, if HTTPS and TCP-TLS routers listen on the same EntryPoint, the HTTPS routers will apply *before* the TCP-TLS routers. |
|
Shifting all changes of the PR to #10510 due to too many merge conflicts caused by the rebase |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #10186
Adds the correction on TCP-TLS routers
More