Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runtime.Object in routerTransform #10523

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Use runtime.Object in routerTransform #10523

merged 1 commit into from
Mar 15, 2024

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 14, 2024

What does this PR do?

For extensibility reasons, this PR changes the type in the routerTransform to runtime.Object.

More

Co-authored-by: lbenguigui lbenguigui@gmail.com

@traefiker traefiker added this to the 3.0 milestone Mar 14, 2024
lbenguigui
lbenguigui approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@lbenguigui lbenguigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtribotte
rtribotte approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d582e01 into traefik:v3.0 Mar 15, 2024
23 checks passed
@kevinpollet kevinpollet changed the title runtime.Object in routerTransform Use runtime.Object in routerTransform Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@rtribotte rtribotte rtribotte approved these changes

@lbenguigui lbenguigui lbenguigui approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s/gatewayapi area/provider/k8s/ingress area/provider/k8s kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juliens @mmatur @rtribotte @lbenguigui @kevinpollet @traefiker