Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve middleware example #10532

Merged
merged 4 commits into from Mar 28, 2024
Merged

Improve middleware example #10532

merged 4 commits into from Mar 28, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Mar 18, 2024 •
edited

What does this PR do?

Specify that namespace option of middleware is optional.

Motivation

Shows that Middleware in the same namespace that IngressRoute can be used without specifying it.

More

  • Added/updated documentation

Additional Notes

Supersede #10525, which was closed by mistake.

@traefiker traefiker added this to the 2.11 milestone Mar 18, 2024
@mloiseleur mloiseleur mentioned this pull request Mar 18, 2024
Merged
1 task
@emilevauge
Copy link
Member

Thanks @mloiseleur, I would be even more verbose on the description, why not explain your use case directly?

Shows that Middleware in the same namespace that IngressRoute can be used without specifying it.

@mloiseleur
Copy link
Contributor Author

I have made another proposal in ecb22dd. Wdyt ?

rtribotte
rtribotte approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevinpollet
kevinpollet approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

lbenguigui
lbenguigui approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lbenguigui lbenguigui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 167bdb0 into traefik:v2.11 Mar 28, 2024
22 checks passed
@rtribotte rtribotte changed the title docs: improve middleware example Improve middleware example Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@rtribotte rtribotte rtribotte approved these changes

@lbenguigui lbenguigui lbenguigui approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mloiseleur @emilevauge @kevinpollet @rtribotte @lbenguigui @mmatur @traefiker