Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support regexp in path/pathprefix in matcher v2 #10546

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Support regexp in path/pathprefix in matcher v2 #10546

merged 3 commits into from
Apr 2, 2024

Conversation

youkoulayley
Copy link
Contributor

What does this PR do?

This PR brings back the support of regexp in the v2 matchers: Path and PathPrefix.

Motivation

Fixes #10542

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@youkoulayley youkoulayley added this to the 3.0 milestone Mar 27, 2024
mmatur
mmatur approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdelicata sdelicata self-requested a review March 28, 2024 13:24
@jspdown jspdown requested review from jspdown and removed request for sdelicata March 28, 2024 13:24
rtribotte
rtribotte approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdelicata
sdelicata requested changes Mar 28, 2024
View reviewed changes
pkg/muxer/http/matcher_v2.go Outdated Show resolved Hide resolved
pkg/muxer/http/matcher_v2.go Outdated Show resolved Hide resolved
jspdown
jspdown approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

youkoulayley and others added 3 commits April 2, 2024 12:30
@youkoulayley @traefiker
fix: support regexp in path/pathprefix in matcher v2
382fbcf
@youkoulayley @sdelicata @traefiker
Update pkg/muxer/http/matcher_v2.go
6a24fd9 
Co-authored-by: Simon Delicata <simon.delicata@free.fr>
@youkoulayley @sdelicata @traefiker
Update pkg/muxer/http/matcher_v2.go
cf49981 
Co-authored-by: Simon Delicata <simon.delicata@free.fr>
@traefiker traefiker merged commit fc897f6 into traefik:v3.0 Apr 2, 2024
22 checks passed
@kevinpollet kevinpollet changed the title fix: support regexp in path/pathprefix in matcher v2 Support regexp in path/pathprefix in matcher v2 Apr 10, 2024
@kevinpollet kevinpollet mentioned this pull request May 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@jspdown jspdown jspdown approved these changes

@sdelicata sdelicata sdelicata approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/rules kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@youkoulayley @mmatur @jspdown @sdelicata @rtribotte @traefiker