Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and improve explanation on internal resources #10563

Merged
merged 1 commit into from Apr 4, 2024
Merged

Fix typo and improve explanation on internal resources #10563

merged 1 commit into from Apr 4, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Apr 3, 2024 •
edited

What does this PR do?

  1. Fix a typo in migration guide
  2. Explains what are internal resources, using the same example than in the migration guide

Motivation

Better documentation.

More

  • Added/updated documentation

@traefiker traefiker added this to the 3.0 milestone Apr 3, 2024
kevinpollet
kevinpollet approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

rtribotte
rtribotte approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

nmengin
nmengin approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2c6418e into traefik:v3.0 Apr 4, 2024
22 checks passed
@kevinpollet kevinpollet changed the title docs: fix typo and improve explanation on internal resources Fix typo and improve explanation on internal resources Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@nmengin nmengin nmengin approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mloiseleur @kevinpollet @nmengin @rtribotte @traefiker