Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace underscores to dash in autogenerated urls (docker provider) #1061

Merged
merged 3 commits into from Feb 6, 2017
Merged

Replace underscores to dash in autogenerated urls (docker provider) #1061

merged 3 commits into from Feb 6, 2017

Conversation

WTFKr0
Copy link
Contributor

@WTFKr0 WTFKr0 commented Jan 24, 2017

Closes #1043

@SantoDE
Copy link
Collaborator

SantoDE commented Jan 27, 2017

Hey @WTFKr0 ,

thank's for your contribution :) Can you rebase your branch please, so it fires off again with travis and stuff?

Thanks :-)

WDYT @vdemeester ?

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@Russell-IO Russell-IO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @WTFKr0

@emilevauge
Copy link
Member

@WTFKr0 some tests are failing, could you have a look ?

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Feb 6, 2017

Don't know what are these errors...
Don't think my code do that :D

----------------------------------------------------------------------
PASS: docker_test.go:128: DockerSuite.TestDockerContainersWithLabels	1.689s
PASS: docker_test.go:164: DockerSuite.TestDockerContainersWithOneMissingLabels	1.717s
PASS: docker_test.go:78: DockerSuite.TestSimpleConfiguration	0.504s
PASS: consul_test.go:399: ConsulSuite.TestCommandStoreConfig	3.556s
ERRO[0026] Datastore sync error: Object lock value: expected 1420e2ba-072f-4e6f-a4e5-8e35963a4c6a, got 2842cf2a-43be-4c70-9a37-1cd4567f5c75, retrying in 253.203223ms 
ERRO[0028] Datastore sync error: Object lock value: expected 4e8bcb9e-08d1-4052-addb-7eeaae6ecf58, got 349e3145-e94a-4e41-8114-3221668c0fa4, retrying in 641.745199ms 
[...]
ERRO[0060] Datastore sync error: Object lock value: expected 1c774173-66b0-44e4-ac27-148cdf0f0666, got c94f37f4-ea07-4baf-919f-1060e2e66f53, retrying in 572.685001ms 
ERRO[0060] Datastore sync error: Object lock value: expected e377c3f7-222f-4e16-b465-e9b032bf79db, got 1c774173-66b0-44e4-ac27-148cdf0f0666, retrying in 356.18893ms 
PASS: consul_test.go:440: ConsulSuite.TestDatastore	39.698s
PASS: consul_test.go:249: ConsulSuite.TestGlobalConfiguration	3.473s
PASS: consul_test.go:126: ConsulSuite.TestNominalConfiguration	4.301s
PASS: consul_test.go:108: ConsulSuite.TestSimpleConfiguration	3.769s

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Feb 6, 2017

Ok I saw it :

FAIL: docker_test.go:96: DockerSuite.TestDefaultDockerContainers
docker_test.go:117:
    c.Assert(resp.StatusCode, checker.Equals, 200)
... obtained int = 404
... expected int = 200

I look

Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
Signed-off-by: WTFKr0 <thomas.kovatchitch@gmail.com>
@emilevauge emilevauge merged commit 28054a0 into traefik:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants