Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the new http3 config in migration #10673

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

yyewolf
Copy link
Contributor

@yyewolf yyewolf commented May 1, 2024

What does this PR do?

This PR improves the migration guide.
It addresses the http3 section to include a link to the new http3 configuration in order to help in transitioning.

Motivation

When reading the migration like it felt like http3 was removed while it was not.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 3.0 milestone May 1, 2024
@yyewolf yyewolf changed the title add link to new http3 config in migration Add link to new http3 config in migration May 1, 2024
@yyewolf yyewolf changed the title Add link to new http3 config in migration Add link to the new http3 config in migration May 1, 2024
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yyewolf,

Thank you for your contribution.
Please find my review below.

docs/content/migration/v2-to-v3.md Outdated Show resolved Hide resolved
@yyewolf
Copy link
Contributor Author

yyewolf commented May 2, 2024

The changes I made include both of your suggestions since both made sense to me

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yyewolf .

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sdelicata sdelicata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a415040 into traefik:v3.0 May 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants