Fix typo in PathRegexp explanation #10719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpollet
added
area/documentation
kind/bug/fix
nmengin
approved these changes
May 15, 2024
There was a problem hiding this comment.
Hey @BreadInvasion,
Thank you for your contribution.
LGTM 👍
One of the example entries for PathRegexp mistakenly used the HostRegexp declaration instead. This renames that incorrect example.
kevinpollet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a minor typo in the examples for the PathRegexp matcher. One of the examples mistakenly used HostRegexp when PathRegexp was clearly intended.
Motivation
I was just reading up on Traefik routing for my current personal project, noticed the typo, and figured I'd leave the place better than I found it.
More
Additional Notes
N/A